Nico Weber 2b6713d3b8 [lld/coff] Fix assert on /start-lib foo.obj /end-lib during eager loads (#120292) ...

If foo.obj is eagerly loaded (due to a prior undef referencing one if
its symbols) and has more than one symbol, we used to assert:
SymbolTable::addLazyObject() for the first symbol would set `lazy` to
false and load all symbols from the file, but the outer
ObjFile::parseLazy() loop would continue to run and call addLazyObject()
for the second symbol, which would assert.

Instead, just stop adding lazy symbols if the file got loaded for real
while adding a symbol.

(The ELF port has a similar early exit in `ObjFile<ELFT>::parseLazy()`.)

2024-12-19 11:22:29 -05:00

51 KiB

Raw Blame History

View Raw